[Resolved] Auto download after urd upgrade (1.10 to 1.13)

[ProD]

I've been having troubles since upgrading, this one I can't seem to get past.
I can't seem to get autodownload working again.  I referred to the link below a bit.
http://urdland.com/forum/index.php?topic=539.0

I have autodownload enabled in all 3 places (admin/config/global, admin/users/<account> and settings/preferences/downloading).
I have search terms set in downloading which when I browse a relevant group get highlighted.  There are items which do not indicate they have been read.  I also have download as nzb enabled, did try disabling that, still didn't autodownload.

When I do update a group, which has matching sets that have not been auto-downloaded or manually selected yet, I do not see an "fn:auto_download" in the log (set to debug before doing the update).


The following 2 items may not be relevant...
I had several errors with the automated update (uncaught exceptions I think) but eventually after several attempts I got to the normal interface.

I had an odd problem where when I updated groups it would say that the group didn't exist.  I updated the group list (added 2 items) and group updates started working.

[spearhead]

The problem with the not existing group sounds familiar.. but I can't find what cause is .... updating the group list will solve this. It seems to only happen after an update of URD

The exceptions you found during the update, I haven't seen those before and shouldn't happen. Do you still have them?

Regarding the autodownload, I'll have to look into that further.... possibly tomorrow.

[ProD]

They were a bit different each time like failure to add or remove columns/keys.  If the errors had been identical each time or it failed in general to eventually run (4 failures iirc, though hours between some of those) I might have kept them...  I didn't notice the auto-download failure until about 2 days after I started the upgrade process.



At this point the only thing not working (as near as I can tell) is the auto-download, I managed to stumble my way through the others.

[spearhead]

Okay I found the problem. You need to apply these changes in the file functions/sets_marking.php :

Note the @@ line numbers @@ may be a bit off but it is an indication where about there are. A - means remove line, a + means add that line instead.

Code:

@@ -526,8 +528,8 @@
-        $maxsetsize = get_pref($prefs, $userID, 'maxsetsize', 0);
-        $minsetsize = get_pref($prefs, $userID, 'minsetsize', 0);
+        $maxsetsize = get_pref($db, $userID, 'maxsetsize', 0);
+        $minsetsize = get_pref($db, $userID, 'minsetsize', 0);

Code:

@@ -599,8 +601,8 @@

-        $maxsetsize = get_pref($prefs, $userID, 'maxsetsize', 0);
-        $minsetsize = get_pref($prefs, $userID, 'minsetsize', 0);
+        $maxsetsize = get_pref($db, $userID, 'maxsetsize', 0);
+        $minsetsize = get_pref($db, $userID, 'minsetsize', 0)

@@ -699,11 +701,12 @@
-        $maxsetsize = get_pref($prefs, $userID, 'maxsetsize', 0);
-        $minsetsize = get_pref($prefs, $userID, 'minsetsize', 0);
+        $maxsetsize = get_pref($db, $userID, 'maxsetsize', 0);
+        $minsetsize = get_pref($db, $userID, 'minsetsize', 0);
+        $setcompleteness = get_pref($db, $userID, 'setcompleteness', 0);
-        $Qcomplete = " AND (\"articlesmax\"=0 OR floor(\"binaries\" * 100 / $GREATEST(1, \"articlesmax\")) >= {$prefs['setcompleteness']})";/// euah ... the horror... but it is ansi sql compliant... no refers to as fields in where clauses ...
+        $Qcomplete = " AND (\"articlesmax\"=0 OR floor(\"binaries\" * 100 / $GREATEST(1, \"articlesmax\")) >= {$setcompleteness})";/// euah ... the horror... but it is ansi sql compliant... no refers to as fields in where clauses ...

Code:

@@ -776,7 +779,7 @@
-            if (($auto_download > 0) && (get_pref($db, 'use_auto_download', $user_id, 0) > 0) && !urd_user_rights::is_autodownloader($db, $user_id)) {
+            if (($auto_download > 0) && (get_pref($db, 'use_auto_download', $user_id, 0) > 0) && urd_user_rights::is_autodownloader($db, $user_id)) {

Alternatively you could grab this one, and replace the current one with it:
http://urd.googlecode.com/svn/trunk/branches/devel/functions/sets_marking.php

And don't forget to restart URDD!

[ProD]

Appears to be fixed (went the editing route) in testing - A small group with binaries semi-randomly picked a binary to auto-download (in settings/preferences/downloading/auto highlight) to nzb and the nzb showed up after manual updating.

Thanks much!

[spearhead]

Great! Thx for reporting....